fix: allow optional types for remote query/command/prerender functions#15293
Open
dummdidumm wants to merge 1 commit intomainfrom
Open
fix: allow optional types for remote query/command/prerender functions#15293dummdidumm wants to merge 1 commit intomainfrom
dummdidumm wants to merge 1 commit intomainfrom
Conversation
We're using the `arg: undefined extends Input ? Input | void : Input` method and not the `...args: undefined extends Input ? [arg?: Input] : [arg: Input]` method because the former does work in more cases (the latter throws a type error in our own code around generics), even though the TS team likely wants us to use the latter (but that pattern is in so many code bases now that this behavior around `void` will never change). One drawback (of either method) is that without strict mode all commands/queries/prerenders have optional args now, because `undefined extends X` is always `true` in non-strict mode. But since noone who uses type checking nowadays should use non-strict mode anyway, it's fine. fixes #14500
🦋 Changeset detectedLatest commit: d8d8ad1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using the
arg: undefined extends Input ? Input | void : Inputmethod and not the...args: undefined extends Input ? [arg?: Input] : [arg: Input]method because the former does work in more cases (the latter throws a type error in our own code around generics), even though the TS team likely wants us to use the latter (but that pattern is in so many code bases now that this behavior aroundvoidwill never change).One drawback (of either method) is that without strict mode all commands/queries/prerenders have optional args now, because
undefined extends Xis alwaystruein non-strict mode. But since noone who uses type checking nowadays should use non-strict mode anyway, it's fine.fixes #14500
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.