(feat) be able to type props/events/slots#437
Draft
dummdidumm wants to merge 1 commit intosveltejs:masterfrom
Draft
(feat) be able to type props/events/slots#437dummdidumm wants to merge 1 commit intosveltejs:masterfrom
dummdidumm wants to merge 1 commit intosveltejs:masterfrom
Conversation
Through a new reserved interface "ComponentDef"
Member
|
Maybe we can add a dummy helper function like |
|
Hey guys, any idea when this will be completed? 👼 |
Member
Author
|
This implementation will very likely not land in this form. This RFC is where the discussion is happening and the details are specified. After that the implementation will follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through a new reserved interface
ComponentDefSee new tests for examples.
Generics
Problem to be solved: Generics. We cannot use
instanceOf(ComponentName)anymore, because this way we cannot pass in the information about the type of the generic.If we have
Child:
Parent:
We need a transformation that makes sure that
iShouldBeOfTypeStringactually is inferred asstring. My current idea is to transform this tonew Child({props: {...allPropsAndItsValuesThatAreDefinedOnTheChild}}).$oninstead of the oldinstanceOf(Child).$on.A completely different idea is to somehow use Function Components instead of Class components. But I'm not sure if we can use this with all the other constraints we have.
Thoughts?