This repository was archived by the owner on Oct 13, 2022. It is now read-only.
Open
Conversation
Before this change, upgrading this project to typescript and enabling strict null checks would throw the following error :
```
> @rollup/plugin-typescript TS2322: Type 'Element | null' is not assignable to type 'Node'.
Type 'null' is not assignable to type 'Node'.
4 target: document.querySelector("#sapper"),
~~~~~~
src/node_modules/@sapper/index.d.ts:20:32
20 export function start(opts: { target: Node }): Promise<void>;
~~~~~~
The expected type comes from property 'target' which is declared here on type '{ target: Node; }'
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, upgrading this project to typescript and enabling strict null checks would throw the following error :