Draft
Conversation
|
Someone is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
I'm still not sure what is better: remounting app (simplier) or replacing iframe (would clean up globals, timers, intervas, etc). |
Member
|
Reloading the entire iframe would be better since intervals is probably the thing I'd use this most for |
* feat: relative github links * make it work with tutorials, dedupe logic * lint * more * link to org
* fix: make repl console scrollable * try this * try this * i think i fixed it? * apply suggestion from review Co-authored-by: Tee Ming <chewteeming01@gmail.com> * Apply suggestion from @eltigerchino --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com>
returnType for example can itself contain other AST-like nodes, which would be traversed by context.next(), leading to "cannot override across a split point" magic string errors
- fix `let a!: number;` - fix `function a(x?: number)`
…ltejs#1532) * fix(llms): preserve newlines in generated `llms-medium.txt` file * chore(llms): remove `normalize_whitespace` functionality
error object might be augmented, see https://github.com/rollup/rollup/blob/76a3b8ede4729a71eb522fc29f7d550a4358827b/docs/plugin-development/index.md#thiserror, hence only check that the specific abort property we set is there
- on startup we had two requests each time due to the svelte version changes in sveltejs#1319, and the file was always marked as changed. Fixed by not notifying when the version info comes from the bundle worker - migrate had two bundle requests, one from the direct `rebundle()` call, the second one because `update_file` invoked `on_update` that also invoked `rebundle()` -> remove the direct invocation - `reset` always did two request, because `this.set` already calls `#onreset` -> deduplicate
walk children of assignment expressions as they could have dynamic requires Should help with techniq/layerchart#512
…eltejs#1537) * feat: add new cmd in the Playground `sv create --from-playground` * css > alert * title & aria-label Co-authored-by: Rich Harris <rich.harris@vercel.com> * button text Co-authored-by: Rich Harris <rich.harris@vercel.com> * remove implicit size Co-authored-by: Rich Harris <rich.harris@vercel.com> * position & mask Co-authored-by: Rich Harris <rich.harris@vercel.com> --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>
* chore: bump kit * Sync `kit` docs (sveltejs#1539) sync kit docs Co-authored-by: svelte-docs-bot[bot] <196124396+svelte-docs-bot[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: svelte-docs-bot[bot] <196124396+svelte-docs-bot[bot]@users.noreply.github.com>
…eltejs#1544) * chore(tutorial/select-bindings): remove unnecessary `$state` * chore(tutorial/select-bindings): removed `$state` rune in app-b
Contributor
Author
|
hm, something went not really well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1126
The button just re-mounts the App, but maybe re-instantiating the entire iframe, to clean up forgotten timers etc., would be better.
The button location isn't the best one - there is no address bar, like in the tutorial or SvelteLab, so alternatives are the console head and before the buttons Fork and Save the REPL. But I find them a bit too far from the tab.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.