import FoundationEssentials instead of Foundation when available#798
Closed
t089 wants to merge 1 commit intoswift-server:mainfrom
Closed
import FoundationEssentials instead of Foundation when available#798t089 wants to merge 1 commit intoswift-server:mainfrom
t089 wants to merge 1 commit intoswift-server:mainfrom
Conversation
Collaborator
|
Indeed it is. See apple/swift-crypto#317 for the full discussion. |
Contributor
|
Hey @t089 - with the recent announcement from ESG about adopting Are you up for bringing the PR up to date and getting it submitted? Otherwise I can also do it, if you don't have the time 👍 |
Contributor
Author
|
@madsodgaard please feel free to open a new PR :) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
import Foundationwithimport FoundationEssentialswhen available.Linking
Foundationon Linux comes with a significant binary size increase due to the included icu data. None of this is necessary for the HTTP client. Instead we can useFoundationEssentialsto get access to the essential types likeURL,Data,Date, ... without including icu data.According to @Lukasa, sadly, this might be a semver major change. :(