Fix crash when response completes before request body finishes uploading#895
Merged
fabianfett merged 3 commits intoswift-server:mainfrom Mar 3, 2026
Merged
Fix crash when response completes before request body finishes uploading#895fabianfett merged 3 commits intoswift-server:mainfrom
fabianfett merged 3 commits intoswift-server:mainfrom
Conversation
glbrntt
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fatalError("Invalid state: idle")crash inHTTP1ConnectionStateMachine.demandMoreResponseBodyParts()that occurs when a response completes before the request body finishes uploadingself.requestwas only nilled out inside the write-completion callback for.sendRequestEnd, creating a window wheredemandResponseBodyStreamcould still see the old request and call into the state machine after it had already transitioned to .idleself.requestsynchronously when handling.sendRequestEnd(before the write completes), and movesrequestBodyStreamSent()to fire after the final action rather than before it