Skip to content

Improve test output readability, reducing redundant logs #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktoso merged 2 commits into from
Feb 5, 2026
Merged

Improve test output readability, reducing redundant logs #552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c0ceaf
improve readability of assertion
sidepelican Feb 2, 2026
368dcaf
Follow swift 6.1.3
sidepelican Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 13 additions & 19 deletions Tests/JExtractSwiftTests/Asserts/TextAssertions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,17 +110,15 @@ func assertOutput(

var diffLineNumbers: [Int] = []
guard let matchingOutputOffset else {
print("error: Output did not contain expected chunk!".red)

print("==== ---------------------------------------------------------------")
print("Expected output:")
print("'\(expectedChunk.yellow)'")
print("==== ---------------------------------------------------------------")
print("Got output:")
print(output)
print("==== ---------------------------------------------------------------")

#expect(output.contains(expectedChunk), sourceLocation: sourceLocation)
let outputContainsExpectedChunk = output.contains(expectedChunk)
#expect(outputContainsExpectedChunk, """
\("error: Output did not contain expected chunk!".red)
==== Expected output -----------------------------------------------
\(expectedChunk.yellow)
==== Got output ----------------------------------------------------
\(output)
==== ---------------------------------------------------------------
""", sourceLocation: sourceLocation)
continue
}

Expand Down Expand Up @@ -183,17 +181,15 @@ func assertOutput(
if hasDiff {
print("error: Number of not matching lines: \(diffLineNumbers.count)!".red)

print("==== ---------------------------------------------------------------")
print("Expected output:")
print("==== Expected output -----------------------------------------------")
for (n, e) in expectedLines.enumerated() {
let isMismatch = diffLineNumbers.map({$0 - matchingOutputOffset}).contains(n)
let marker = isMismatch ? " // <<<<<<<<<<< mismatch" : ""
print("\(n): \(e)\(marker)".yellow(if: isMismatch))
}
}

print("==== ---------------------------------------------------------------")
print("Got output:")
print("==== Got output ----------------------------------------------------")
let printFromLineNo = matchingOutputOffset
for (n, g) in gotLines.enumerated() where n >= printFromLineNo {
let baseLine = "\(n): \(g)"
Expand Down Expand Up @@ -246,17 +242,15 @@ func assertOutput(
if hasDiff {
print("error: Number of not matching lines: \(diffLineNumbers.count)!".red)

print("==== ---------------------------------------------------------------")
print("Expected output:")
print("==== Expected output -----------------------------------------------")
for (n, e) in expectedLines.enumerated() {
let isMismatch = diffLineNumbers.contains(n)
let marker = isMismatch ? " // <<<<<<<< error: mismatch" : ""
print("\(e)\(marker)".yellow(if: isMismatch))
}
}

print("==== ---------------------------------------------------------------")
print("Got output:")
print("==== Got output ----------------------------------------------------")
for (n, g) in gotLines.enumerated() {
let isMismatch = diffLineNumbers.contains(n)
let marker = isMismatch ? "// <<<<<<<< error: mismatch" : ""
Expand Down
Loading