Skip static requirements in protocols#553
Open
sidepelican wants to merge 2 commits intoswiftlang:mainfrom
Open
Skip static requirements in protocols#553sidepelican wants to merge 2 commits intoswiftlang:mainfrom
sidepelican wants to merge 2 commits intoswiftlang:mainfrom
Conversation
ktoso
approved these changes
Feb 6, 2026
Collaborator
ktoso
left a comment
There was a problem hiding this comment.
Lgtm but please add a note to the features list that this isn't supported
Contributor
Author
|
Actually, I realized there is a slight gap in this implementation. JavaInterfaceProtocolWrapper cannot be generated when there are static requirements, we will need to skip it in those cases as well. That said, this PR still provides an improvement as-is. |
Collaborator
|
That's fine, let's merge this and follow up then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when generating Java code from a Swift protocol (JNI only),
staticrequirements are mapped directly tostaticmethods in a Javainterface.However, unlike Swift protocols, Java interfaces do not support 'static requirements'. This leads to the following compilation errors:
While there might be a design pattern to introduce 'static requirements' in Java, this feels like a complex change with many points of contention that would require significant time.
To ensure the generated code is compilable, this PR updates the generator to ignore them.