Skip to content

feature: move organization select to top #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caebr merged 1 commit into from
Nov 11, 2025
Merged

feature: move organization select to top #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/app/components/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@
const checkPubliccodeYmlVersion = useCallback((publicCode: PublicCode) => {
const { publiccodeYmlVersion } = publicCode;
setPubliccodeYmlVersion(publiccodeYmlVersion);
}, []);

Check warning on line 238 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useCallback has a missing dependency: 'setPubliccodeYmlVersion'. Either include it or remove the dependency array

Check warning on line 238 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useCallback has a missing dependency: 'setPubliccodeYmlVersion'. Either include it or remove the dependency array

const checkItCountryExtensionVersion = useCallback(
(publicCode: PublicCode) => {
Expand All @@ -255,7 +255,7 @@

setShowCountryExtensionVersion(countryExtensionVersionVisible);
},
[]

Check warning on line 258 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useCallback has a missing dependency: 'setShowCountryExtensionVersion'. Either include it or remove the dependency array

Check warning on line 258 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useCallback has a missing dependency: 'setShowCountryExtensionVersion'. Either include it or remove the dependency array
);

useFormPersist("form-values", {
Expand All @@ -267,7 +267,7 @@
checkPubliccodeYmlVersion(pc);
checkItCountryExtensionVersion(pc);
},
[setLanguages]

Check warning on line 270 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useCallback has missing dependencies: 'checkItCountryExtensionVersion' and 'checkPubliccodeYmlVersion'. Either include them or remove the dependency array

Check warning on line 270 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useCallback has missing dependencies: 'checkItCountryExtensionVersion' and 'checkPubliccodeYmlVersion'. Either include them or remove the dependency array
),
storage: window?.localStorage, // default window.sessionStorage
exclude: [],
Expand Down Expand Up @@ -485,7 +485,7 @@
yamlLoadEventBus.off("loadRemoteYaml", loadRemoteYamlHandler);
yamlLoadEventBus.off("loadFileYaml", loadFileYamlHandler);
};
}, []);

Check warning on line 488 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useEffect has missing dependencies: 'loadFileYamlHandler' and 'loadRemoteYamlHandler'. Either include them or remove the dependency array

Check warning on line 488 in src/app/components/Editor.tsx

View workflow job for this annotation

GitHub Actions / test 

React Hook useEffect has missing dependencies: 'loadFileYamlHandler' and 'loadRemoteYamlHandler'. Either include them or remove the dependency array

return (
<div className="content__editor-wrapper">
Expand Down Expand Up @@ -513,6 +513,13 @@
<EditorInput<"applicationSuite"> fieldName="applicationSuite" />
</span>
</div>
<div className="mt-5">
<EditorSelect<"organisation.uri">
fieldName="organisation.uri"
data={organisations}
filter="contains"
/>
</div>
<div className="bd-highlight">
<PubliccodeYmlLanguages />
</div>
Expand All @@ -530,14 +537,14 @@
{isDeprecatedFieldVisible(
`description.${lang}.genericName` as never
) && (
<span>
<EditorDescriptionInput<"genericName">
fieldName="genericName"
lang={lang}
deprecated
/>
</span>
)}
<span>
<EditorDescriptionInput<"genericName">
fieldName="genericName"
lang={lang}
deprecated
/>
</span>
)}
<div className="mt-5">
<EditorDescriptionInput<"localisedName">
fieldName="localisedName"
Expand Down Expand Up @@ -581,7 +588,7 @@
</span>
</div>
<div>
<EditorDescriptionInput<"longDescription">
<EditorDescriptionInput<"longDescription">
fieldName="longDescription"
lang={lang}
required
Expand All @@ -606,13 +613,6 @@
<span>
<EditorInput<"isBasedOn"> fieldName="isBasedOn" />
</span>
<div className="mt-5">
<EditorSelect<"organisation.uri">
fieldName="organisation.uri"
data={organisations}
filter="contains"
/>
</div>
<div className="mt-4 mb-4">
<EditorFundedBy />
</div>
Expand Down
Loading