Feat/eidomni 544 reusing rust crypto logic #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from DID Resolver 2.5.0)
…the new VerificationMethodKeyProvider impl. DalekEd25519VerificationMethodKeyProviderImpl
…roviderImpl minimized
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/ch/admin/bj/swiyu/didtoolbox/DalekEd25519VerificationMethodKeyProviderImpl.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/DalekEd25519VerificationMethodKeyProviderImpl.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/DalekEd25519VerificationMethodKeyProviderImpl.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/ProofOfPossessionVerifier.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/VerificationMethodKeyProviderException.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/DalekEd25519ProofOfPossessionJWSSignerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/ProofOfPossessionVerifier.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/VerificationMethodKeyProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/webvh/WebVerifiableHistoryCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/Ed25519VerificationMethodKeyProviderImpl.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/ch/admin/bj/swiyu/didtoolbox/TdwDeactivator.java
Dismissed
Show dismissed
Hide dismissed
...n/java/ch/admin/bj/swiyu/didtoolbox/vc_data_integrity/VcDataIntegrityCryptographicSuite.java
Fixed
Show fixed
Hide fixed
| // throw new AccessDeniedException("Access denied to " + outputDir.getPath() + " due to: " + ex.getMessage()); | ||
| } catch (Throwable thr) { | ||
| throw new IOException("Failed to create private directory " + pathname + " due to: " + thr.getMessage()); | ||
| throw new DidLogCreatorStrategyException("Failed to create private directory " + pathname + " due to: " + thr.getMessage()); |
Check warning
Code scanning / PMD
Thrown exception does not preserve the stack trace of exception 'e' on all code paths Warning
Comment on lines
+383
to
+385
| matchingUpdateKey = publicKeyEd25519Multibase; | ||
| break; | ||
| } | ||
| } catch (VcDataIntegrityCryptographicSuiteException ignoreMalformedPemFiles) { | ||
| } |
Check warning
Code scanning / PMD
Deeply nested if..then statements are hard to read Warning
| try { | ||
| this.updateKeys = WebVerifiableHistoryDidLogMetaPeeker.peek(didLog).getParams().getUpdateKeys(); // assume a did:webvh log | ||
| } catch (DidLogMetaPeekerException exc1) { // not a did:webvh log | ||
| throw new ProofOfPossessionVerifierException(exc1); |
Check warning
Code scanning / PMD
Thrown exception does not preserve the stack trace of exception 'e' on all code paths Warning
.../admin/bj/swiyu/didtoolbox/vc_data_integrity/VcDataIntegrityCryptographicSuiteException.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/context/DidLogCreatorContext.java
Show resolved
Hide resolved
...min/bj/swiyu/didtoolbox/vc_data_integrity/EdDsaJcs2022VcDataIntegrityCryptographicSuite.java
Outdated
Show resolved
Hide resolved
...min/bj/swiyu/didtoolbox/vc_data_integrity/EdDsaJcs2022VcDataIntegrityCryptographicSuite.java
Outdated
Show resolved
Hide resolved
...min/bj/swiyu/didtoolbox/vc_data_integrity/EdDsaJcs2022VcDataIntegrityCryptographicSuite.java
Show resolved
Hide resolved
...n/java/ch/admin/bj/swiyu/didtoolbox/vc_data_integrity/VcDataIntegrityCryptographicSuite.java
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/Ed25519Utils.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/ch/admin/bj/swiyu/didtoolbox/Ed25519Utils.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/ch/admin/bj/swiyu/didtoolbox/webvh/WebVerifiableHistoryCreator.java
Dismissed
Show dismissed
Hide dismissed
MarcelPfeuti
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.