Feat/eidomni 450 supply prerotation-key as EcPublicKey #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duced for DidLog[Creator|Updater]Context
…IDOMNI-450-supply-prerotation-key-as-ecpublickey
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/ch/admin/bj/swiyu/didtoolbox/context/NextKeyHashSource.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/context/NextKeyHashSourceException.java
Fixed
Show fixed
Hide fixed
…ed accordingly. Deprecations introduced
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameter.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/webvh/WebVerifiableHistoryCreator.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameter.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameter.java
Fixed
Show fixed
Hide fixed
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameter.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameterException.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/UpdateKeysDidMethodParameter.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/UpdateKeysDidMethodParameterException.java
Dismissed
Show dismissed
Hide dismissed
MarcelPfeuti
requested changes
Jan 27, 2026
Collaborator
MarcelPfeuti
left a comment
MarcelPfeuti
left a comment
There was a problem hiding this comment.
In general I like the changes to the API. However, I feel like it's not yet a full step. Rather than offer new methods with the desired parameters (no files, keys directly), the method parameter have been extended. Instead of providing the files, both files and keys have to be provided now. Imo it should be that keys or files can be provided, but not both.
I personally would go a step further (in a version 2.0) and remove the files from the parameters alltogether. The creation and management of dids does not depend on the file system whatsoever. Rather it depends on the keys, and our API should reflect that.
Of course we can provide helper methods, to covert files into the correct keys.
src/main/java/ch/admin/bj/swiyu/didtoolbox/context/DidLogStrategyFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/context/DidLogStrategyFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/DidLogMeta.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameter.java
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/NextKeyHashesDidMethodParameter.java
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/UpdateKeysDidMethodParameter.java
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/model/UpdateKeysDidMethodParameter.java
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/webvh/WebVerifiableHistoryDeactivator.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/admin/bj/swiyu/didtoolbox/webvh/WebVerifiableHistoryUpdater.java
Outdated
Show resolved
Hide resolved
MarcelPfeuti
approved these changes
Jan 29, 2026
vst-bit
deleted the
feat/EIDOMNI-450-supply-prerotation-key-as-ecpublickey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.