(feat) added --port-forward and --background flags#4
Open
zeylos wants to merge 1 commit intosylvinus:mainfrom
Open
(feat) added --port-forward and --background flags#4zeylos wants to merge 1 commit intosylvinus:mainfrom
zeylos wants to merge 1 commit intosylvinus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
What
This PR adds
limactl --port-forwardflag) to forward additional ports to the hostnohupanddisown.Why
This allows the user to do stuff like that to access the session from a Web browser, a Desktop app or an IDE on the host
Screenshots
?
--backgroundand--rmto be exclusive or not, for now it's explicitely exclusive because I don't see any usecase where we'd want both + it's probably tricky to get the exit event from the disowned process to trigger the destroy.