Skip to content

fmt: allow version 9 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pandapip1 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −10
Draft

fmt: allow version 9 #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2be22
fmt: allow version 9 and later
Pandapip1 Jun 27, 2025
8a93754
spdlog: allow newer versions again now that fmt isn't an issue anymore
Pandapip1 Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion gen/cpp/sym/util/type_ops.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions symforce/opt/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ include(FetchContent)
# ------------------------------------------------------------------------------
# fmtlib

find_package(fmt 8...<9 QUIET)
find_package(fmt 8 QUIET)
if (NOT fmt_FOUND)
message(STATUS "fmt not found, adding with FetchContent")
function(add_fmt)
Expand All @@ -34,7 +34,7 @@ endif()
# ------------------------------------------------------------------------------
# spdlog

find_package(spdlog 1.9...<1.11 QUIET)
find_package(spdlog 1.9 QUIET)
if (NOT spdlog_FOUND)
message(STATUS "spdlog not found, adding with FetchContent")
function(add_spdlog)
Expand Down
1 change: 0 additions & 1 deletion symforce/opt/factor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include "./factor.h"

#include <fmt/format.h>
#include <fmt/ostream.h>
#include <fmt/ranges.h>

#include "./assert.h"
Expand Down
1 change: 0 additions & 1 deletion symforce/opt/internal/tic_toc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <algorithm>

#include <fmt/format.h>
#include <fmt/ostream.h>
#include <spdlog/spdlog.h>

namespace sym {
Expand Down
1 change: 0 additions & 1 deletion symforce/opt/tic_toc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@

#else // if !defined(SYMFORCE_TIC_TOC_HEADER)
#include <fmt/format.h>
#include <fmt/ostream.h>

#include "./internal/tic_toc.h"

Expand Down
1 change: 0 additions & 1 deletion symforce/opt/values.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include "./values.h"

#include <fmt/format.h>
#include <fmt/ostream.h>

#include "./assert.h"

Expand Down
1 change: 0 additions & 1 deletion symforce/pybind/cc_factor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#include <Eigen/Core>
#include <fmt/format.h>
#include <fmt/ostream.h>
#include <pybind11/eigen.h>
#include <pybind11/functional.h>
#include <pybind11/pybind11.h>
Expand Down
1 change: 0 additions & 1 deletion symforce/pybind/cc_key.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include "./cc_key.h"

#include <fmt/format.h>
#include <fmt/ostream.h>

#include <symforce/opt/key.h>

Expand Down
1 change: 0 additions & 1 deletion symforce/pybind/cc_values.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

#include <Eigen/Core>
#include <fmt/format.h>
#include <fmt/ostream.h>
#include <pybind11/eigen.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
Expand Down