Convert skymarshal templates from py2 to py3 style annotations #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update skymarshal Python code generation templates to use Python 3-style inline type annotations instead of Python 2-style comment annotations. Changes: - Update python_enum.py.template: convert all method signatures from `# type: (args) -> return` comments to inline `(args: T) -> R` syntax - Update python_struct.py.template: remove quotes from forward-reference return types (e.g., `-> "Name"` becomes `-> Name`) - Add `from __future__ import annotations` to wrapper templates (python_enum_default_wrapper.py.template and python_struct_default_wrapper.py.template) to enable PEP 563 postponed annotation evaluation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Topic: skymarshal-py3-annotations
Member
Author
|
Reviews in this chain: |
Member
Author
asa
pushed a commit
to asa/symforce
that referenced
this pull request
Jan 23, 2026
…e annotations Convert skymarshal templates from py2 to py3 style annotations Update skymarshal Python code generation templates to use Python 3-style inline type annotations instead of Python 2-style comment annotations. Changes: - Update python_enum.py.template: convert all method signatures from `# type: (args) -> return` comments to inline `(args: T) -> R` syntax - Update python_struct.py.template: remove quotes from forward-reference return types (e.g., `-> "Name"` becomes `-> Name`) - Add `from __future__ import annotations` to wrapper templates (python_enum_default_wrapper.py.template and python_struct_default_wrapper.py.template) to enable PEP 563 postponed annotation evaluation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Topic: skymarshal-py3-annotations Closes symforce-org/symforce#451 GitOrigin-RevId: 59feda7d816d6ad99c1de193a7716a1065038fff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update skymarshal Python code generation templates to use Python 3-style
inline type annotations instead of Python 2-style comment annotations.
Changes:
# type: (args) -> returncomments to inline(args: T) -> Rsyntaxreturn types (e.g.,
-> "Name"becomes-> Name)from __future__ import annotationsto wrapper templates(python_enum_default_wrapper.py.template and
python_struct_default_wrapper.py.template) to enable PEP 563
postponed annotation evaluation
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Topic: skymarshal-py3-annotations