This repository was archived by the owner on Sep 7, 2018. It is now read-only.
Add static window wrap method#242
Merged
BenLambertNcl merged 7 commits intosymphonyoss:masterfrom Jul 12, 2017
Merged
Conversation
andy-lee-eng
approved these changes
Jul 12, 2017
| return chainPromises(steps); | ||
| }); | ||
|
|
||
| it.only('Should wrap a native window in a containerjs window object #ssf.Window.wrap', function() { |
Collaborator
There was a problem hiding this comment.
@BenLambertNcl Just noticed this it.only was left in, preventing other tests from running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a wrap method onto the Window class, that allows wrapping a native container window with the ContainerJS window object. Mainly useful internally for methods such as
getParentWindow(), where the native container method returns a native window that we need to convert to a ContainerJS window.