This repository was archived by the owner on Mar 30, 2020. It is now read-only.
Fix: render method was not returning entityInstanceId#27
Open
jrmatos wants to merge 1 commit intosymphonyoss:masterfrom
Open
Fix: render method was not returning entityInstanceId#27jrmatos wants to merge 1 commit intosymphonyoss:masterfrom
jrmatos wants to merge 1 commit intosymphonyoss:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@jrmatos). In order for your PR to be reviewed and merged, please follow the directions at the link above. Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above. If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the render method of the entity renderer service needs to return an entityInstanceId, dynamic rendering was not working because it was sending undefined to the Entity Service update method.