Add preference to hide symbol property text for better map performance #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-for-symbol-properties feat(map): persist symbol properties preference
…ing-signal-to-readfeature Expose symbolPropertiesShowing signal to features
…andle-exceptions test(emitter): assert off without handler
…index.js Fix level JSDoc annotations
Fix typos in PDF header comment
…nt-bug Fix cross-platform cmdOrCtrl detection
…ignal.link Link symbol property preference to modifier updates
…-emission feat: add symbol properties preference toggle
…iew_symbol_properties Listen for symbol properties toggle
…tion-effect Refactor Map initialization effect for proper cleanup
…rformance-hotspots Optimize symbol style updates
…ort-async feat: make import async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added “Show Symbol Properties” toggle to the View → Appearance menu and wired it to ui.symbolProperties.showing so users can enable or disable descriptive text on map symbols.
Introduced a reactive signal for symbolPropertiesShowing that updates feature styling without tearing down and recreating the OpenLayers map.
Linked symbol style computation to the new signal, ensuring modifiers recompute when the preference changes and preventing data loss during toggles.