EN-10353: Add include to to stops, allowing patternHrefs in stop objects#136
Open
EN-10353: Add include to to stops, allowing patternHrefs in stop objects#136
include to to stops, allowing patternHrefs in stop objects#136Conversation
added 3 commits
May 16, 2025 09:40
* add .include to stopsContext
* add { include: string } option to stop .fetch()
* add tests in get_stops.test.js
* update readme to use development tag
jerhemy
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now do the following
This lets you figure out what pattern the stop is associated to without getting patterns which returns an href of the stop with the pattern in the stop href instead of the direct stop href. This may allow O(1) searches on the client for patterns related to a stop (if patterns are in a hashmap) instead of iterating through stop arrays in each pattern.