-
Notifications
You must be signed in to change notification settings - Fork 0
feat: complete adding support for parameterized and registered queries #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimezesinachi
wants to merge
15
commits into
master
Choose a base branch
from
feat/update-where-clause-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9022f33
feat updated WhereClause type to include QueryParameter
jimezesinachi c96c81e
feat: added SqlBuilder handler logic for param()
jimezesinachi 2ca9f27
wip
jimezesinachi e961dcc
fixed tests
jimezesinachi 35607ce
added error methods and fixes
jimezesinachi c4fd1e3
fix: added checker for undefined
jimezesinachi 772b166
updated client and handlers
jimezesinachi b048b66
fixes
jimezesinachi fd284ea
updated docs and minor logic improvements
jimezesinachi 1401f86
more tests, fixes & refactors
jimezesinachi d3030dd
small fixes
jimezesinachi 2cc7f6a
added QueryStore, refactor to use and added parameterized query prope…
jimezesinachi d6eada0
fixes
jimezesinachi a41c1e0
fixes
jimezesinachi 1c6db94
fixes
jimezesinachi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { col, param } from '@synthql/queries'; | ||
| import { queryEngine } from './tests/queryEngine'; | ||
| import { from } from './tests/generated'; | ||
|
|
||
| const params = { | ||
| 'where.actor_id': 2, | ||
| 'where.film_id': 47, | ||
| 'include.film.where.language_id': 3, | ||
| 'include.film.include.language.where.last_update': '2022-02-15 10:02:19+00', | ||
| }; | ||
|
|
||
| describe('QueryEngine', () => { | ||
| it('registerQueries + executeRegisteredQuery', async () => { | ||
| queryEngine.registerQueries([findFilmActor(false).maybe()]); | ||
|
|
||
| const parameterizedQueryResult = | ||
| await queryEngine.executeRegisteredQueryAndWait({ | ||
| queryId: findFilmActor(false).maybe().hash, | ||
| params, | ||
| }); | ||
|
|
||
| const regularQueryResult = await queryEngine.executeAndWait( | ||
| findFilmActor(true).maybe(), | ||
| ); | ||
|
|
||
| expect(parameterizedQueryResult).toEqual(regularQueryResult); | ||
| }); | ||
| }); | ||
|
|
||
| function findFilmActor(regular: boolean) { | ||
| return from('film_actor') | ||
| .where({ | ||
| actor_id: regular ? params['where.actor_id'] : param(), | ||
| film_id: regular ? params['where.film_id'] : param(), | ||
| }) | ||
| .include({ | ||
| film: from('film') | ||
| .where({ | ||
| film_id: col('film_actor.film_id'), | ||
| language_id: regular | ||
| ? params['include.film.where.language_id'] | ||
| : param(), | ||
| }) | ||
| .include({ | ||
| language: from('language') | ||
| .where({ | ||
| language_id: col('film.language_id'), | ||
| last_update: regular | ||
| ? params[ | ||
| 'include.film.include.language.where.last_update' | ||
| ] | ||
| : param(), | ||
| }) | ||
| .maybe(), | ||
| }) | ||
| .maybe(), | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.