-
Notifications
You must be signed in to change notification settings - Fork 14
Make e2e tests cleaner and self-debugging #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jacalata
commented
Oct 8, 2025
- Added initial tests that report if expected assets are not present
- Made the suite fail early if publishing fails (because everything else depends on that)
- Made the filenames unique per run so that re-runs are not affected by earlier passes
- Broke up the test file into classes to separate setup and tests
- change test asset names - make a more reliable way to get unique publishing names for reliability - fix option for -d in extract refresh command
Make tests use new unique names each time, so that re-runs pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactored e2e tests to improve debugging capabilities and test reliability by restructuring test files into separate classes, adding asset validation, implementing unique naming for test runs, and ensuring early failure on publishing issues.
- Reorganized test structure by separating
TabcmdCallutility methods fromOnlineCommandTesttest cases - Added initial asset file validation and unique filename generation per test run
- Implemented early failure mechanism for publishing operations since subsequent tests depend on them
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/e2e/tests_integration.py | Added logger initialization to test methods |
| tests/e2e/online_tests.py | Major refactoring: created TestAssets and TabcmdCall classes, added asset validation, implemented unique naming |
| tests/assets/live_mysql.tds | Added new test asset file containing MySQL datasource configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>