Skip to content

Conversation

@jacalata
Copy link
Contributor

@jacalata jacalata commented Oct 8, 2025

  • Added initial tests that report if expected assets are not present
  • Made the suite fail early if publishing fails (because everything else depends on that)
  • Made the filenames unique per run so that re-runs are not affected by earlier passes
  • Broke up the test file into classes to separate setup and tests

- change test asset names
- make a more reliable way to get unique publishing names for reliability
- fix option for -d  in extract refresh command
Make tests use new unique names each time, so that re-runs pass.
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py101010 0%
   tabcmd.py141414 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py771818 77%
   server.py1302020 85%
tabcmd/commands/auth
   session.py3704646 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1561818 88%
   datasources_workbooks_views_url_parser.py1401010 93%
   delete_command.py601616 73%
   export_command.py1192525 79%
   get_url_command.py1274747 63%
   publish_command.py831919 77%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py3822 95%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2213131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py12588 94%
   localize.py691111 84%
   logger_config.py4266 86%
   tabcmd_controller.py4277 83%
TOTAL276143184% 

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactored e2e tests to improve debugging capabilities and test reliability by restructuring test files into separate classes, adding asset validation, implementing unique naming for test runs, and ensuring early failure on publishing issues.

  • Reorganized test structure by separating TabcmdCall utility methods from OnlineCommandTest test cases
  • Added initial asset file validation and unique filename generation per test run
  • Implemented early failure mechanism for publishing operations since subsequent tests depend on them

Reviewed Changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.

File Description
tests/e2e/tests_integration.py Added logger initialization to test methods
tests/e2e/online_tests.py Major refactoring: created TestAssets and TabcmdCall classes, added asset validation, implemented unique naming
tests/assets/live_mysql.tds Added new test asset file containing MySQL datasource configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jacalata and others added 5 commits October 9, 2025 16:27
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jacalata jacalata merged commit 27fa16e into development Oct 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants