Conversation
50f5c05 to
ee6f91a
Compare
|
Thanks for the PR! Could you add a test for this option? |
|
Added to CI in c7c5a13 |
.github/workflows/ci.yml
Outdated
| codesign: '-' | ||
| codesign-prefix: 'com.example.' | ||
| codesign-options: 'runtime' | ||
| upx: ${{ startsWith(matrix.os, 'ubuntu-') && matrix.target != 'x86_64-pc-windows-gnu' && matrix.target != 'aarch64-unknown-linux-gnu' }} |
There was a problem hiding this comment.
- Is the reason it doesn't work with aarch64 and windows-gnu because UPX doesn't support cross-compilation?
(It seems that aarch64 is supported? https://github.com/upx/upx/blob/d00ba4b4656837c08841bd8f9599fda87bb7c7d2/src/p_lx_elf.h#L533) - Is it intentional that this is only tested in linux? Have there been any problems when tested otherwise?
There was a problem hiding this comment.
See https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/
Is the reason it doesn't work with aarch64 and windows-gnu because UPX doesn't support cross-compilation?
Is it intentional that this is only tested in linux? Have there been any problems when tested otherwise?
win64/arm64is not yet supported- macOS is not supported
There was a problem hiding this comment.
Is the reason it doesn't work with aarch64 and windows-gnu because UPX doesn't support cross-compilation?
It seems to work with aarch64 linux-gnu + build-tool=cargo.
https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/job/34547228655?pr=90
Is it intentional that this is only tested in linux? Have there been any problems when tested otherwise?
win64/arm64is not yet supported- macOS is not supported
This doesn't seem to describe why x86_64 windows is skipped.
https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/job/34547233333?pr=90
There was a problem hiding this comment.
It seems to work with aarch64 linux-gnu + build-tool=cargo.
Added.
This doesn't seem to describe why x86_64 windows is skipped.
The output of the file command is the same when the exe is compressed with UPX or not:
./test-crate/target/release/test-crate.exe: PE32+ executable (console) x86-64 (stripped to external PDB), for MS Windows
See this run (compressing) and this run (not compressing). I don't know how to test it.
Co-authored-by: Taiki Endo <te316e89@gmail.com>
50ba508 to
74e34ce
Compare
|
UPX appears to greatly reduce the program size. I'm really looking forward to using it! |
|
Hi @taiki-e |
Add
upxoption to compress binaries with UPX on Windows and Linux (see https://upx.github.io).Contributes to #6