v2/logging: add support for S3 logstreaming#131
Merged
Conversation
oxtoacart
reviewed
Jan 23, 2025
oxtoacart
reviewed
Jan 23, 2025
Contributor
oxtoacart
left a comment
oxtoacart
left a comment
There was a problem hiding this comment.
Generally LGTM, just a comment about the style for passing parameters.
We recently added support for S3 logstreaming endpoints to our API. This involved adding several new fields on the GET LogstreamConfiguration and PUT LogstreamConfiguration endpoints (and a new destinationType, "s3"), plus a new AWSExternalID resource and two new endpoints related to it. This commit updates the Go client library to reflect all of these changes. Updates tailscale/corp#24533 Signed-off-by: Zach Hauser <zehauser@gmail.com>
zehauser
force-pushed
the
zach/s3-logstreaming
branch
from
c84613b to
9148e23
Compare
oxtoacart
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently added support for S3 logstreaming endpoints to our API. This involved adding several new fields on the GET LogstreamConfiguration and PUT LogstreamConfiguration endpoints (and a new destinationType, "s3"), plus a new AWSExternalID resource and two new endpoints related to it.
This commit updates the Go client library to reflect all of these changes.
Updates tailscale/corp#24533