fix regressions triggered by (c)ontinue calls during a session#30
Open
CodeGuro wants to merge 1 commit intotamentis:masterfrom
Open
fix regressions triggered by (c)ontinue calls during a session#30CodeGuro wants to merge 1 commit intotamentis:masterfrom
CodeGuro wants to merge 1 commit intotamentis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were also a couple other issues...
First and foremost, this resolves the regression described in issue #29 caused by commit 18cd5a4. We want to allow the debugger to continue, but we don't want to close the connection on the socket until it's actually time to shut down (EOF or SIGQUIT or an exception occurs etc).
Secondly, the replacement of the sys.stdin and sys.stdout as file objects is not enough - we want to update the underlying file descriptor because there may be some other underlying object that saved/uses the old stdin/stdout. As such, to we use dup2 to ensure subsequent reads/writes go into the socket. Though honestly, it's a bit redundant because the PDB/BDB class inherits the Cmd class which reads from the socket implicitly anyway (passing the socket handle as stdin/stdout is sufficient).
Anyway, this should at least make it functional again.