Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a create2 method to deploy semaphore using a deterministic address.
Related Issue
tangle-network/protocol-solidity#208
Does this introduce a breaking change?
Other information
The deployer class and contracts are currently duplicated. This is due to a circular dependency while development (need to use Deployer from protocol-solidity to deploy using create2, but I need a deterministic deployer for semaphore on
https://github.com/webb-tools/protocol-solidity/pull/218. After we merge the protocol-solidity PR we can remove these files and import them accordingly