tests: enhance functional test with more checks. #77
Conversation
pponnuvel
force-pushed
the
enhance-ft
branch
5 times, most recently
from
a741dbd to
8e84cfc
Compare
pponnuvel
force-pushed
the
enhance-ft
branch
7 times, most recently
from
40e36fb to
f47fac3
Compare
Fixes SET-1807. Fixes taodd#24. Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
taodd
left a comment
taodd
left a comment
There was a problem hiding this comment.
Some minor change required.
@pponnuvel thank you very much for the patch. The osdtrace works great, However, from the log output, it seems radostrace still can't output anything.
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
Thanks @taodd! I've fixed the issue with radostrace now. All look fine now - please take a look again. Thanks. |
| info "=== Test Summary ===" | ||
| info "✓ MicroCeph cluster deployed successfully" | ||
| info "✓ osdtrace captured $OSD_LINE_COUNT lines of trace data" | ||
| info "✓ osdtrace output validated: $LINES_VALIDATED lines checked, 0 errors" |
There was a problem hiding this comment.
LINES_VALIDATED is undefined, do you mean to set this value to the number of traced lines in osdtrace log?
|
|
||
| # 14.3 Check the correct pool id is used | ||
| TEST_POOL_ID=$(microceph.ceph osd pool ls detail | grep "^pool.*'test_pool'" | grep -oP "pool \K\d+") | ||
| pool_id_err=$(awk -v p_id=$TEST_POOL_ID '$1=="osd" && $2=="pg"{split($4, a, "."); if (a[0] != p_id) {print a[0]; exit}}' $OSDTRACE_LOG) |
There was a problem hiding this comment.
the array created by the split method in awk seems to start from index 1, therefore a[0] is always empty, a[1] is the pool id, a[2] is the pg id
| echo "✓ osdtrace successfully captured trace data" | ||
| # 14.4 Check PG ranges in the test pool | ||
| TOT_PG=$(microceph.ceph osd pool get test_pool pg_num | awk '{print $2}') | ||
| pg_range_err=$(awk -v tot=$TOT_PG '$1=="osd" && $2=="pg"{split($4, a, "."); pg=strtonum(a[1]); if (pg < 0 || pg >= tot)print a[1]}' $OSDTRACE_LOG) |
There was a problem hiding this comment.
same as above, the pg id should be a[2]
taodd
left a comment
taodd
left a comment
There was a problem hiding this comment.
Except the suggested comments.
The radostrace still doesn't output any trace line in the log file.
I guess it's probably because we need to specify the process id of the microceph.rbd bench command, if that's the case we'll need to adjust the order of step 10 and step 11.
add -p to the radostrace. then we should see the actual tracing data from radostrace
2 participants
Fixes SET-1807.