This repository was archived by the owner on Dec 15, 2017. It is now read-only.
Configuration options for hour/minute/second stepping#217
Open
pascalhein wants to merge 2 commits intotarruda:masterfrom
pascalhein:master
Open
Configuration options for hour/minute/second stepping#217pascalhein wants to merge 2 commits intotarruda:masterfrom pascalhein:master
pascalhein wants to merge 2 commits intotarruda:masterfrom
pascalhein:master
Conversation
Added the configuration options hourStep (defaults to 1), minuteStep (defaults to 1), secondStep (defaults to 1). Each of them determines the number of units the arrows will change the hours, minutes and seconds, respectively. That is, if hourStep is 4 and the time in the datetimepicker currently has a hour value of 17, clicking on the up arrow will change that value to 17+4=21, and clicking on the down arrow will change it to 17-4=13. This also wraps around 0 and 24, so that decrementing 00:05:00 with a minuteStep of 6 will give 23:59:00. Also adjusted three test cases to reflect the new behavior. Those test cases expected the click to effect a change of 1, which is the default value, but they now expect a change of the step values given in the setup function.
|
👍 |
1 similar comment
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the configuration options
hourStep (defaults to 1),
minuteStep (defaults to 1),
secondStep (defaults to 1).
Each of them determines the number of units the arrows will change the hours,
minutes and seconds, respectively. That is, if hourStep is 4 and the time in
the datetimepicker currently has a hour value of 17, clicking on the up arrow
will change that value to 17+4=21, and clicking on the down arrow will change
it to 17-4=13.
This also wraps around 0 and 24, so that decrementing 00:05:00 with a
minuteStep of 6 will give 23:59:00.
Also adjusted three test cases to reflect the new behavior. Those test cases
expected the click to effect a change of 1, which is the default value, but
they now expect a change of the step values given in the setup function.