This repository was archived by the owner on Dec 15, 2017. It is now read-only.
Update the hide method to fix scroll#241
Open
LiamKarlMitchell wants to merge 1 commit intotarruda:masterfrom
Open
Update the hide method to fix scroll#241LiamKarlMitchell wants to merge 1 commit intotarruda:masterfrom
LiamKarlMitchell wants to merge 1 commit intotarruda:masterfrom
Conversation
Bootstrap.js binds on hidden on the bs.modal so you want to trigger that.
$(document)
.on('show.bs.modal', '.modal', function () { $(document.body).addClass('modal-open') })
.on('hidden.bs.modal', '.modal', function () { $(document.body).removeClass('modal-open') })
Otherwise the body tag will keep the modal-open tag and you cant scroll because it does overflow:none;
c9s
added a commit
to corneltek/bootstrap-datetimepicker
that referenced
this pull request
May 23, 2016
c9s
added a commit
to corneltek/bootstrap-datetimepicker
that referenced
this pull request
May 23, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datetime modal currently triggers 'hide', while the modal binding is expecting 'hidden.bs.modal'.
This causes the 'hidden' event to not get triggered, meaning that body scroll never gets re-enabled.