-
Notifications
You must be signed in to change notification settings - Fork 2
Make wikilinks and tags clickable in focus view #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
44b0f0b
Add design doc for Create Person command
tavva 912e3e1
Add implementation plan for Create Person command
tavva b9c0227
Add personsFolderPath and personTemplateFilePath settings
tavva 627d460
Add People Folder and Person Template settings to settings tab
tavva 619cd0e
Add FileWriter.createPerson with template support
tavva ee6ff1e
Add NewPersonModal for creating person notes
tavva 6d7d0dd
Register create-person command in plugin
tavva bab0e4e
Format code
tavva ca5feb4
Add Templater integration to createPerson
tavva e36d124
Auto-select sphere when only one is configured
tavva 73ada3f
Merge pull request #39 from tavva/fix/auto-select-single-sphere
tavva 2cca593
Release v1.2.2
tavva a5679c0
Preserve scroll position when adding actions to Focus
tavva d76a294
Preserve scroll via data-before-empty instead of CSS-only updates
tavva 3a9ea46
Wait for async renders before restoring scroll position
tavva 7670d9c
Suppress rerender when focus change originates from sphere view
tavva 4109255
Replace full refresh with targeted updates for focus changes
tavva 15702f4
Update sphere view dynamically when action converts to waiting-for
tavva 328f967
Clean up workspace event refs on re-registration
tavva e647785
Merge pull request #42 from tavva/fix/preserve-scroll-on-focus-add
tavva 1d04ed8
Release v1.2.3
tavva 24b4994
Update AGENTS.md to reflect current architecture and remove dead code
tavva b9c8ca5
Add design doc for GTD context tag filtering
tavva 6eeb4d0
Add implementation plan for context tag filtering
tavva bc9a06a
Merge main into beta
tavva bb8e19d
Render focus action text as markdown for clickable wikilinks and tags
tavva c10787c
Handle clicks on rendered links and tags in focus view
tavva 1cb4d7e
Guard against non-HTMLElement click targets in handleRenderedTextClick
tavva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Create Person Command | ||
|
|
||
| ## Summary | ||
|
|
||
| Add a "Create person" command to the Flow plugin so users can scaffold person notes via the command palette, mirroring the existing "Create new project" command pattern. | ||
|
|
||
| Prompted by [Discussion #35](https://github.com/tavva/flow/discussions/35). | ||
|
|
||
| ## Components | ||
|
|
||
| ### 1. Settings additions | ||
|
|
||
| - `personsFolderPath: string` (default `"People"`) — folder where person notes are created | ||
| - `personTemplateFilePath: string` (default `"Templates/Person.md"`) — path to person template file | ||
|
|
||
| Both configurable in the settings tab. | ||
|
|
||
| ### 2. Default person template | ||
|
|
||
| ```markdown | ||
| --- | ||
| creation-date: {{ date }}T{{ time }} | ||
| tags: person | ||
| --- | ||
|
|
||
| ## Discuss next | ||
| ``` | ||
|
|
||
| Template variables: `{{ date }}` (YYYY-MM-DD), `{{ time }}` (HH:MM:00) — same as the project template. | ||
|
|
||
| ### 3. NewPersonModal | ||
|
|
||
| A simple modal with: | ||
| - Name text input (required) | ||
| - Creates file at `{personsFolderPath}/{sanitizedName}.md` | ||
| - Reads template from `personTemplateFilePath`, falls back to hardcoded default if template file missing | ||
| - Replaces `{{ name }}`, `{{ date }}`, `{{ time }}` template variables | ||
| - Errors if file already exists | ||
| - Opens the file after creation | ||
|
|
||
| ### 4. Command registration | ||
|
|
||
| `addCommand` in `main.ts` with id `create-person`, name `Create person`, wired to open `NewPersonModal`. Same pattern as "Create new project". | ||
|
|
||
| ## What's excluded | ||
|
|
||
| - No sphere/priority/status — person notes don't use these | ||
| - No AI integration | ||
| - No pre-population of "Discuss next" items | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add required project frontmatter and sections for markdown compliance.
This doc is missing the required YAML frontmatter and the Title/Description/Next actions sections expected for Flow project markdown files.
✅ Suggested structure
As per coding guidelines "Flow projects must follow the project structure with YAML frontmatter including creation-date, priority, tags (project/*), status, and optional parent-project, followed by title, description, and next actions sections".
🤖 Prompt for AI Agents