Merged
Conversation
added 3 commits
January 20, 2026 09:22
Implements logic to skip non-admin jobs when the database is unavailable, ensuring only admin jobs proceed in admin-only mode. Introduces a method for submitting job errors via gRPC service with a default timeout setting. Adjusts job start conditions to streamline initialization process. Relates to branch: allow-job-stream-without-database
its unimplemented currently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
GateClientJobStreamto improve how jobs are handled when the plugin is not running, particularly for admin api requests. The main enhancement is that non-admin jobs are now explicitly rejected with an error message if the database is unavailable, and this error is reported back to the server. Several helper methods and imports were also added to support this functionality.Job handling improvements:
submitJobErrormethod. [1] [2] [3]isAdminJobwas introduced to identify admin-only jobs, allowing them to bypass the plugin running check.Codebase enhancements:
SubmitJobResultsRequestimport and a newsubmitJobErrormethod to encapsulate error submission logic. [1] [2]DEFAULT_TIMEOUT_SECONDSconstant and importedTimeUnitto standardize gRPC request timeouts. [1] [2]start()method to only check for configuration, aligning with the new job handling logic.