Open
Conversation
While it's arguably for rescuing timeouts, it's wrong to swallow all exceptions. For example, I spent about an hour figuring out why webmock doesn't work for zester, while it worked everywhere else. By default, webmock disables all http requests, and raises exceptions with suggestion to mock it. But in case with zester, it returned just `Web services are currently unavailable`, which was really weird: webmock seemed not working and API call was made, but Zillow returned an error about unavailability. After all I had to debug to this method. If exceptions were not swallowed, it was clear where the problem is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's arguably for rescuing timeouts, it's wrong to swallow all
exceptions.
For example, I spent about an hour figuring out why webmock doesn't work
for zester, while it worked everywhere else. By default, webmock disables
all http requests, and raises exceptions with suggestion to mock it. But
in case with zester, it returned just
Web services are currently unavailable, which was really weird: webmock seemed not working and APIcall was made, but Zillow returned an error about unavailability.
After all I had to debug to this method.
If exceptions were not swallowed, it was clear where the problem is.