[GTASA] Wrapped update-function in try-catch to fix crashing on Linux#5
Open
Goldiedtv wants to merge 1 commit intotduva:masterfrom
Open
[GTASA] Wrapped update-function in try-catch to fix crashing on Linux#5Goldiedtv wants to merge 1 commit intotduva:masterfrom
Goldiedtv wants to merge 1 commit intotduva:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autosplitter works othewise fine, but if SA crashes or you need to reset, Livesplit crashed and froze ~8 times out of 10 either when SA's exe closed or started. Because apparently under Linux, if the Autosplitter throws an exception, it crashes the whole LiveSplit (source: Autosplitters on Linux blogpost).
Wrapping the update-function in try-catch and just returning false on catch seems to fix the issue completely and this shouldn't affect the normal operation of the Autosplitter.