Fix kwargs in assert_*_of_selectors methods in minitest#2829
Open
Jealrock wants to merge 1 commit intoteamcapybara:masterfrom
Open
Fix kwargs in assert_*_of_selectors methods in minitest#2829Jealrock wants to merge 1 commit intoteamcapybara:masterfrom
assert_*_of_selectors methods in minitest#2829Jealrock wants to merge 1 commit intoteamcapybara:masterfrom
Conversation
Jealrock
changed the title
assert_*_of_selectors methods in minitest
Jealrock
force-pushed
the
fix-kwargs-in-multiple-selector-asserts
branch
from
582d975 to
a8d2060
Compare
Jealrock
force-pushed
the
fix-kwargs-in-multiple-selector-asserts
branch
from
a8d2060 to
ccbb27f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
assert_*_of_selectorson self in minitest the kwargs get pushed to args.To reproduce replace
assert_all_of_selectors(:css, 'select#form_other_title', 'input#form_last_name')withassert_all_of_selectors(:css, 'select#form_other_title', "input#form_super_secret", visible: false)in minitest_spec.rb.The fix is to just use the right generator method in minitest.rb