Update dependencies to latest version#1
Open
codewithtyler wants to merge 5 commits intotech256:masterfrom
codewithtyler:update-dependencies
Open
Update dependencies to latest version#1codewithtyler wants to merge 5 commits intotech256:masterfrom codewithtyler:update-dependencies
codewithtyler wants to merge 5 commits intotech256:masterfrom
codewithtyler:update-dependencies
Conversation
iamvery
reviewed
Apr 9, 2019
Member
There was a problem hiding this comment.
We might want to just remove the versions from the Gemfile entirely. How did you decide whether this change is good? Were you able to run it in some form locally?
Update: Just saw your comment in the description. I'll try to have a look 🔜. Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@iamvery when you get a chance can you set up a PR pipeline on the Heroku app and then set add a review app so that we can verify the app actually runs before we merge this PR? I was able to partially start the app but since I don't have redis and whatever else installed on my laptop I couldn't really test it locally to make sure nothing broke as a result of updating the dependencies.