Fix: Explicitly import Handlebars in translations/index.ts instead of relying on global#3967
Merged
stephenhand merged 2 commits intoCHI-3736-mask_notificationsfrom Feb 26, 2026
Merged
Conversation
5 tasks
…ing on global Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on CHI-3736: Mask identifiers in notifications
Fix: Explicitly import Handlebars in translations/index.ts instead of relying on global
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lookupTranslationcalledHandlebars.compile(...)without importinghandlebars, relying implicitly on the global injected by the Flex runtime. This caused a fragile dependency and forced tests to manually injectglobal.Handlebars.Description
translations/index.ts: Added explicitimport Handlebars from 'handlebars'— package was already a declared dependencytranslations/index.test.ts: RemovedbeforeAll/afterAllblocks that injected/cleaned upglobal.HandlebarsChecklist
Other Related Issues
None
Verification steps
Run
npx jest src/___tests__/translations/index.test.tsinplugin-hrm-form— all 8 tests pass.AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.