CHI-3736: Mask identifiers in browser notifications#3975
Merged
stephenhand merged 2 commits intoCHI-3736-mask_notificationsfrom Feb 27, 2026
Merged
CHI-3736: Mask identifiers in browser notifications#3975stephenhand merged 2 commits intoCHI-3736-mask_notificationsfrom
stephenhand merged 2 commits intoCHI-3736-mask_notificationsfrom
Conversation
5 tasks
…deletion Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix masking of identifiers in browser notifications
CHI-3736: Mask identifiers in browser notifications
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the standard new message notification title with a localized masked variant when
VIEW_IDENTIFIERSis denied, and removes theIncomingTasknotification entirely (modifying it doesn't work). Fixes broken unit tests caused by the missingNotificationsmock and adds coverage for the notification deletion.Test fixes (
maskIdentifiers/index.test.ts):@twilio/flex-uimock now includesNotifications.registeredNotifications(Map created inline in factory to avoid Jest hoisting issues withconst)IncomingTaskadded to mockedNotificationIdsmockRegisteredNotificationsaccessed via the imported module reference post-mockNew test coverage:
IncomingTaskis deleted fromregisteredNotificationswhenVIEW_IDENTIFIERSis deniedIncomingTaskis NOT deleted whenVIEW_IDENTIFIERSis grantedChecklist
Other Related Issues
None
Verification steps
Run
npm testinplugin-hrm-form— allmaskIdentifierstests pass.AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.