test: Improve unit test coverage for webchat pre-engagement form components [CHI-3696]#3976
Merged
gpaoloni merged 4 commits intogian_CHI-3696from Feb 27, 2026
Merged
test: Improve unit test coverage for webchat pre-engagement form components [CHI-3696]#3976gpaoloni merged 4 commits intogian_CHI-3696from
gpaoloni merged 4 commits intogian_CHI-3696from
Conversation
6 tasks
…3696] Co-authored-by: gpaoloni <15805319+gpaoloni@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Implement rendering of webchat pre-engagement form
test: Improve unit test coverage for webchat pre-engagement form components [CHI-3696]
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds validation logic and comprehensive test coverage for the pre-engagement form components introduced in the parent PR. Covers all
FormInputTypevariants supported in webchat forms (Input,Email,Select,DependentSelect,Checkbox).Changes
validation.tsvalidateEmailPatternto skip validation for empty values — optional email fields no longer produce errors when blankPreEngagementFormPhase.tsxvalidateInput(usinggetDefaultValuefor type-correct defaults per field type) beforefetchAndStoreNewSessionis called; aborts submission if any field has an errorPreEngagementFormPhase.test.tsxform validationtest block covering all fiveFormInputTypetypes, assertingfetchAndStoreNewSessionis not called when:requiredfield is empty (Input, Email, Select, DependentSelect, Checkbox)EMAIL_PATTERNNew component test files (
__tests__/Input.test.tsx,Checkbox.test.tsx,Select.test.tsx,DependentSelect.test.tsx)**erroris non-null,onBlurcallshandleChangewith correct{ name, value }DependentSelectadditionally assertssetItemValueis called to reset the dependent select when the dependee value changesChecklist
Other Related Issues
Parent PR: #3865 (form definitions), #3897 (form rendering)
Verification steps
Run
npm testinaselo-webchat-react-app— all 314 tests pass.AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.