Skip to content

chore: ignore no-op to avoid triggering DLQ message#1033

Merged
gpaoloni merged 1 commit intomasterfrom
gian_CHI-3762
Mar 5, 2026
Merged

chore: ignore no-op to avoid triggering DLQ message#1033
gpaoloni merged 1 commit intomasterfrom
gian_CHI-3762

Conversation

@gpaoloni
Copy link
Collaborator

@gpaoloni gpaoloni commented Mar 2, 2026

Description

Because of the changes introduced in #996, the no-op "delete non-existing document" started returning error result, which is interpreted as a "failed to process message". These messages are now reaching the DLQ (again). This PR fixes this regression.

Checklist

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@gpaoloni gpaoloni requested a review from stephenhand March 2, 2026 20:03
@gpaoloni gpaoloni changed the title chore: swallow no-op to avoid triggering DLQ message chore: ignore no-op to avoid triggering DLQ message Mar 3, 2026
@gpaoloni gpaoloni merged commit 09a60bd into master Mar 5, 2026
30 of 31 checks passed
@gpaoloni gpaoloni deleted the gian_CHI-3762 branch March 5, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants