chore(deps): Change Sentry to branch main#93
Closed
philprime wants to merge 4 commits intophilprime/sentry-spmfrom
Closed
chore(deps): Change Sentry to branch main#93philprime wants to merge 4 commits intophilprime/sentry-spmfrom
main#93philprime wants to merge 4 commits intophilprime/sentry-spmfrom
Conversation
main
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the app and share extension to use the SentrySPM Swift Package product (compile-from-source) instead of importing Sentry / SentrySwiftUI directly, updating Xcode/SwiftPM metadata and the generated license listings accordingly.
Changes:
- Replace
import Sentry/import SentrySwiftUIwithimport SentrySPMacross app + share extension sources. - Update the Xcode project’s Swift Package product dependencies to use
SentrySPM. - Update
Package.resolvedand the Settings.bundle license metadata to reflect the new Sentry dependency source/versioning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Targets/ShareExtension/Sources/ShareViewController.swift | Switch import to SentrySPM for the share extension’s Sentry usage. |
| Targets/App/Sources/Utils/SentryMetricsHelper.swift | Switch import to SentrySPM for metrics helper usage. |
| Targets/App/Sources/UI/MainContainerView.swift | Switch import to SentrySPM for SwiftUI tracing integration. |
| Targets/App/Sources/UI/LinkLists/LinkListsContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/LinkListInfo/LinkListInfoContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/LinkListDetail/LinkListDetailContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/LinkInfo/LinkInfoContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/LinkDetailNFCSharing/LinkDetailNFCSharingViewModel.swift | Switch import to SentrySPM for Sentry metrics/capture usage. |
| Targets/App/Sources/UI/LinkDetailNFCSharing/LinkDetailNFCSharingContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/LinkDetail/LinkDetailRenderView.swift | Switch import to SentrySPM. |
| Targets/App/Sources/UI/LinkDetail/LinkDetailContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/CreateListEditor/CreateLinkListEditorContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/CreateLinkWithoutListEditor/LinkListPickerContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/CreateLinkWithoutListEditor/CreateLinkWithListPickerEditorContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/UI/CreateLinkEditor/CreateLinkEditorContainerView.swift | Switch imports to a single SentrySPM import. |
| Targets/App/Sources/Services/QRCodeCache.swift | Switch import to SentrySPM for capture/breadcrumb usage. |
| Targets/App/Sources/Services/DataSeedingService.swift | Switch import to SentrySPM for capture/breadcrumb usage. |
| Targets/App/Sources/Services/AppHealthObserver.swift | Switch import to SentrySPM for metrics/breadcrumb usage. |
| Targets/App/Sources/Resources/Settings.bundle/Licenses.plist | Update displayed Sentry license title metadata. |
| Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt | Update generated license-plist result metadata for Sentry. |
| Targets/App/Sources/Main/FlinkyApp.swift | Switch import to SentrySPM for app startup configuration. |
| Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Update sentry-cocoa resolution to main branch + revision. |
| Flinky.xcodeproj/project.pbxproj | Replace Sentry/SentrySwiftUI package products with SentrySPM and update package reference requirements. |
Comments suppressed due to low confidence (2)
Flinky.xcodeproj/project.pbxproj:690
- The Flinky app target’s SentrySPM package reference looks inconsistent: the target depends on a PBXTargetDependency whose productRef is D4C71A17, but packageProductDependencies lists D410FC5C instead. These should reference the same XCSwiftPackageProductDependency to avoid Xcode/SPM resolution and linking issues.
packageProductDependencies = (
D4CFD1782E1E38F2001447E9 /* SFSafeSymbols */,
D44A62A52E33B2800018D789 /* OnLaunch */,
D410FC5C2F3C8AAB0028B18D /* SentrySPM */,
);
Flinky.xcodeproj/project.pbxproj:716
- The ShareExtension target has a similar SentrySPM mismatch: dependencies uses a PBXTargetDependency pointing at productRef D4C71A15, but packageProductDependencies lists D4C71A13. Align these to a single SentrySPM product dependency entry so the target consistently resolves/links the package product.
name = ShareExtension;
packageProductDependencies = (
D4C71A132F3C8B05006E688D /* SentrySPM */,
);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Closed in favor of #92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.