Conversation
Generated by 🚫 Danger Swift against 1fbd5f9 |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR migrates the TPPDF library to Swift 6 with strict concurrency checking enabled by updating the Swift tools version from 5.9 to 6.1 and adding necessary Sendable conformances throughout the codebase.
Key changes:
- Updated Swift tools version from 5.9 to 6.1 in Package.swift
- Added Sendable conformance to various public types (structs, enums, and classes)
- Changed static variables to static constants in test files for thread safety
- Marked test helper static variable as
nonisolated(unsafe)where needed
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Updated Swift tools version from 5.9 to 6.1 |
| Source/API/Utils/CrossPlattformGraphics.swift | Added Sendable conformance to RectCorner OptionSet and changed static properties to constants |
| Source/API/Table/Style/PDFTableCellStyle.swift | Added @unchecked Sendable conformance for thread safety |
| Source/API/Table/Style/PDFTableCellBorders.swift | Added Sendable conformance |
| Source/API/Table/PDFTableCell.swift | Added @unchecked Sendable conformance |
| Source/API/Image/PDFImageOptions.swift | Added Sendable conformance to OptionSet |
| Source/API/Graphics/PDFLineType.swift | Added Sendable conformance to enum |
| Source/API/Graphics/PDFLineStyle.swift | Added Sendable conformance |
| Tests/TPPDFTests/PDFGenerator+Generation_Spec.swift | Marked test helper static variable as nonisolated(unsafe) for concurrency safety |
| Tests/TPPDFTests/Graphics/PDFLineType_Spec.swift | Changed allTests from var to let for immutability |
| Tests/TPPDFTests/Graphics/PDFLineStyle_Spec.swift | Changed allTests from var to let for immutability |
| Tests/TPPDFTests/Graphics/PDFLineStyle_Equatable_Spec.swift | Changed allTests from var to let for immutability |
| Tests/TPPDFTests/Graphics/PDFLineSeparatorObject_Spec.swift | Changed allTests from var to let for immutability |
| Tests/TPPDFTests/Graphics/PDFLineSeparatorObject+Equatable_Spec.swift | Changed allTests from var to let for immutability |
| Tests/TPPDFTests/Graphics/PDFGraphics_Spec.swift | Changed allTests from var to let for immutability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.