fix: correct RectCorner.allCorners bit calculation

[philprime]

Summary

• Fixed operator precedence bug in RectCorner.allCorners calculation
• Added Swift Testing test suite for RectCorner

Details

The expression 1 << 4 - 1 was evaluating to 1 << 3 (8) due to operator precedence, instead of the intended value 15 representing all four corners. Fixed by adding parentheses: (1 << 4) - 1.

Changes

• Source/API/Utils/CrossPlattformGraphics.swift: Fixed allCorners calculation
• Tests/TPPDFTests/Utils/RectCornerTests.swift: Added comprehensive test suite

Test Plan

• All 6 new Swift Testing tests pass
• Verified allCorners raw value equals 15 (0b1111)
• Verified allCorners contains all individual corners
• Verified OptionSet operations work correctly

[techprimate-bot]

	Warnings
⚠️	The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity	File	Reason
Warning	RectCornerTests.swift:6	Header comments should be consistent with project patterns. (file_header)
Warning	CrossPlattformGraphics.swift:209	Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)

Generated by 🚫 Danger Swift against 8a9afbe

[Copilot]

Pull request overview

This PR fixes a critical operator precedence bug in the RectCorner.allCorners calculation and adds comprehensive test coverage for the RectCorner type. The bug caused allCorners to have a raw value of 8 instead of the intended 15, which would have prevented it from correctly representing all four corners in the OptionSet.

Key Changes:

• Fixed operator precedence in allCorners by adding parentheses: changed 1 << 4 - 1 to (1 << 4) - 1
• Added comprehensive Swift Testing test suite with 6 tests covering individual corners, combinations, and OptionSet operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
Source/API/Utils/CrossPlattformGraphics.swift	Fixed allCorners calculation from evaluating to 8 (incorrect) to 15 (correct) by correcting operator precedence
Tests/TPPDFTests/Utils/RectCornerTests.swift	Added comprehensive test suite verifying individual corner values, allCorners value, OptionSet operations, and raw value initialization

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.