Skip to content

Conversation

@jjzha
Copy link
Contributor

@jjzha jjzha commented Jan 5, 2026

Link to issue: #22

Description

Added the SkillSkape dataset (https://aclanthology.org/2024.nlp4hr-1.4.pdf). I modified the tasks/ranking/skill_extraction.py file by adding a SkillSkape class and the corresponding test and imports. I was not sure if this is satisfactory, because I did not know whether to add the SkillSkape class in a new file as the task is almost identical to TECH and HOUSE.

If needed, I can split it up. But then would like to know what to call the file (e.g., skill_extraction_skillskape.py?).

Checklist

  • Added new tests for new functionality
  • Tested locally with example tasks
  • Code follows project style guidelines
  • Documentation updated
  • No new warnings introduced

@Mattdl Mattdl self-requested a review January 6, 2026 08:08
@Mattdl Mattdl added the enhancement New feature or request label Jan 6, 2026
Copy link
Collaborator

@Mattdl Mattdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fits right in with the existing skill extraction datasets. Great work, thanks for contributing!

@Mattdl Mattdl merged commit 28719eb into techwolf-ai:main Jan 6, 2026
2 checks passed
@Mattdl Mattdl mentioned this pull request Jan 7, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants