Skip to content

Comments

Update rollup-plugin-visualizer to v7.0.0#4778

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
AlanGreene:eslint_rollup_visualizer
Feb 24, 2026
Merged

Update rollup-plugin-visualizer to v7.0.0#4778
tekton-robot merged 1 commit intotektoncd:mainfrom
AlanGreene:eslint_rollup_visualizer

Conversation

@AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Feb 23, 2026

Changes

Replaces #4773

This introduces a breaking change as the package is now ESM only.

Update eslint config to ESM and replace eslint-plugin-import with eslint-plugin-import-x which is a more efficient, lightweight, ESM-first replacement recommended by eslint-plugin-depend's depend/ban-dependencies rule. This addresses issues with the new rollup plugin not being correctly resolved by eslint-plugin-import.

Also update ajv and minimatch to resolve https://github.com/tektoncd/dashboard/security/code-scanning/6 (GHSA-2g4f-4pwh-qvx6 and GHSA-3ppc-4f35-3m26)

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 23, 2026
@AlanGreene AlanGreene force-pushed the eslint_rollup_visualizer branch from 4b9c195 to 5645d3d Compare February 23, 2026 21:14
This introduces a breaking change as the package is now ESM only.

Update eslint config to ESM and replace `eslint-plugin-import`
with `eslint-plugin-import-x` which is a more efficient, lightweight,
ESM-first replacement recommended by `eslint-plugin-depend`'s
`depend/ban-dependencies` rule. This addresses issues with the
new rollup plugin not being correctly resolved by eslint-plugin-import.

Also update `ajv` and `minimatch` to latest patch releases.
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@tekton-robot tekton-robot merged commit fe24dff into tektoncd:main Feb 24, 2026
16 checks passed
@AlanGreene AlanGreene deleted the eslint_rollup_visualizer branch February 24, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants