chore: update stencil to 4 and outputs#2403
chore: update stencil to 4 and outputs#2403christopherGdynia wants to merge 8 commits intotelekom:mainfrom
Conversation
|
Hi @christopherGdynia this is an awesome task that you are helping us with . I just want to remind you that the e2e and the spec tests are failing if you could take the time to check them it would be great , I will also try to take a look when I find the time |
|
Good morning, sure, i am right on it :D Update: Fix UnitTest::
Fix E2E Tests: i am not sure about this one additionally i remeved lodash from "packages/components" aswell needed to turn un skip lib check because of ts errors: |
|
the |
|
I dont know why the uncommited changes fails, i am only building locally I have tried 3 hours debugging and also updating storybook but its not working When we are doing this I need to know: Why is Vue the base? |
|
I understand your frustration :) , storybook is always a headache when it comes to NodeJs update or version update.
This should make the storybook docs run. |
|
If you still faced issues locally, you need to clear the node_modules and run a fresh install, to solve the sub-dependency resolving issues, this could be an issue with |
|
you mean running yarn clean i have tried this multiple times |
|
Just deleting the |
|
Storybook is now running locally BUT: Starting the storybook locally has infinite loading and doesn't show anything |
|
The error in the |
|
Ok, i will do this in 2 steps I will run this on mac and hopefully i will see the changes from the porcelain change |
|
The node option flag isn't recognized inside pr run It's set and run, but not working error: this is thrown for each component |
packages/storybook-vue/package.json
Outdated
| "@storybook/theming": "^6.4.22", | ||
| "@storybook/vue": "^6.4.22", | ||
| "babel-loader": "^8.1.0", | ||
| "babel-loader": "^10.0.0", |
There was a problem hiding this comment.
babel-loader 10.x is not compatible with webpack4. Downgrade this to 8.2.3 and it will fix the build.
amir-ba
left a comment
There was a problem hiding this comment.
the dropdown test (packages\visual-tests\src\dropdown.visual.spec.js) also requires this await page.waitForSelector('#root'); addition.
and also in the hover, active, focus test I recommend adding a
await global.page.waitForSelector('#root > scale-dropdown .input__dropdown');
selector to make sure it is there
c775b4b to
9e2a7f6
Compare
|
Hello @amir-ba when do we merge this change? I can fix the merge conflicts |
|
@christopherGdynia sorry for the delay ,can i ask you to rebase this so we can finally merge it |
9e2a7f6 to
54c969f
Compare
|
@christopherGdynia thanks for fixing this, in such short notice. |
|
I thought about this. I think, maybe to reduce the impact lets put back the depricated events we removed. and remove them in an extra PR later to have a better encapsulation to see what has gone wrong. so can you please put them back in the components package |
Stencil & Tooling Update
This PR upgrades Stencil to v4 and modernizes related build dependencies and output targets. This ensures compatibility with current Node.js environments and incorporates recent tooling improvements.
Key Updates:
- Needed to remove them because of the react output target, it had duplicated event properties
Tested Operations:
Successfully verified the following locally:
Open ToDo & Questions:
Please comment if any missing tasks or overlooked aspects are identified.