feat: add combobox component#2445
Open
popadicbranislav wants to merge 10 commits intotelekom:mainfrom
Open
Conversation
eb3866f to
cc49587
Compare
Contributor
Author
|
Link the issue #1447 |
obstmi
reviewed
Feb 4, 2026
| .example { | ||
| margin-bottom: 4rem; | ||
| padding: 2rem; | ||
| background: #222; |
Contributor
Contributor
There was a problem hiding this comment.
Hi Branislav,
great work! I especially like the perfect documentation.
When I tested the new component (MacOS with Chrome and Firefox), I noticed a few things:
- Floating-UI: sometimes the selected options opens on an unexpected place. It's not always the case, but I'd say in 25-50%. (see Screenshot-1)
- Floating-UI: sometimes you can't select options from the list. Also - like in 1. - it's not always the case and not apparently predictable. If you click on a option, nothing happens. I have the impression, that it happens especially, if the list of options opens above the combobox. (see Screenshot-2)
- UX: Personally, I would assume that the list of options would be filtered using the first letters of the characters entered (e.g., “a” selects everything that starts with “a,” “st” selects everything that starts with “st”). Currently, however, everything that contains ‘a’ or “st” (in this example) is selected.
This means that entering an “e”, for example, results in only a small amount of filtering. (see Screenshot-3)
Contributor
Author
There was a problem hiding this comment.
Hi @obstmi,
Thanks for the feedback.
The example html style is fixed.
To address the points:
- The first issue happens when the items are filtered. I've added the update to position to the filter event.
- Visibility of the dropdown is tied to focus of the input element. This might happen when click handler is longer than delay set to close the dropdown. I changed the event handler to
onMouseDown. - This is quite an opinion based observation, and I understand this. I think the best solution would be to provide an option for consumer to make this decision, using current approach as a fallback. I have added a filterFunction option to the component.
be95062 to
b66fe53
Compare
fb79e8b to
c8945c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Introduce a new combobox component.
TODOs: