Skip to content

fix(database): use singleton serializer factory instead of creating a new one #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendt merged 2 commits into from
Jan 9, 2026
Merged

fix(database): use singleton serializer factory instead of creating a new one #1877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5917b2b
wip
brendt Jan 8, 2026
bc8645b
wip
brendt Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/database/src/DatabaseInitializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ className: Connection::class,
return new GenericDatabase(
connection: $connection,
transactionManager: new GenericTransactionManager($connection),
serializerFactory: new SerializerFactory($container),
serializerFactory: $container->get(SerializerFactory::class),
);
}
}
4 changes: 3 additions & 1 deletion packages/database/src/GenericDatabase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,12 @@ private function resolveBindings(Query $query): array
{
$bindings = [];

$serializerFactory = $this->serializerFactory->in($this->context);

foreach ($query->bindings as $key => $value) {
if ($value instanceof Query) {
$value = $value->execute();
} elseif ($serializer = $this->serializerFactory->in($this->context)->forValue($value)) {
} elseif ($serializer = $serializerFactory->forValue($value)) {
$value = $serializer->serialize($value);
}

Expand Down
2 changes: 2 additions & 0 deletions tests/Integration/Container/TaggedDynamicInitializerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@
use Tempest\Database\Config\SQLiteConfig;
use Tempest\Database\Database;
use Tempest\Database\DatabaseInitializer;
use Tempest\Mapper\SerializerFactory;

final class TaggedDynamicInitializerTest extends TestCase
{
public function test_resolve(): void
{
$container = new GenericContainer();
$container->singleton(SerializerFactory::class, new SerializerFactory($container));
$container->addInitializer(DatabaseInitializer::class);

$container->config(new SQLiteConfig(
Expand Down