Skip to content

remove incorrect block error #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kepe-temporal wants to merge 4 commits into from
Closed

remove incorrect block error #730

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0334ec5
remove incorrect block error
kepe-temporal Jan 23, 2026
de32c02
use conflict token
kepe-temporal Jan 23, 2026
e064714
try with empty string
kepe-temporal Jan 23, 2026
f59107a
test removing unset
kepe-temporal Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 10 additions & 50 deletions features/deployment_versioning/aa_clean_old_deployments/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,11 @@ func ListOldDeployments(ctx context.Context) ([]string, error) {
}

func DeleteDeployment(ctx context.Context, deploymentName string) error {
client := activity.GetClient(ctx)
tClient := activity.GetClient(ctx)
ns := activity.GetInfo(ctx).WorkflowNamespace

deploymentInfo, err := client.WorkflowService().DescribeWorkerDeployment(
// Describe to get version summaries
deploymentInfo, err := tClient.WorkflowService().DescribeWorkerDeployment(
ctx,
&workflowservice.DescribeWorkerDeploymentRequest{
Namespace: ns,
Expand All @@ -81,55 +82,10 @@ func DeleteDeployment(ctx context.Context, deploymentName string) error {
if err != nil {
return fmt.Errorf("failed to describe worker deployment %s: %w", deploymentName, err)
}
// Unset current/ramping versions so things can be deleted
_, err = client.WorkflowService().SetWorkerDeploymentCurrentVersion(ctx, &workflowservice.SetWorkerDeploymentCurrentVersionRequest{
Namespace: ns,
DeploymentName: deploymentName,
Identity: "feature-deployment-deleter",
IgnoreMissingTaskQueues: true,
AllowNoPollers: true,
})
if err != nil {
// Try using unversioned string (needed if deployment was very old)
_, err = client.WorkflowService().SetWorkerDeploymentCurrentVersion(ctx, &workflowservice.SetWorkerDeploymentCurrentVersionRequest{
Namespace: ns,
DeploymentName: deploymentName,
Version: "__unversioned__",
BuildId: "__unversioned__",
Identity: "feature-deployment-deleter",
IgnoreMissingTaskQueues: true,
AllowNoPollers: true,
})
if err != nil {
return fmt.Errorf("failed to unset current version for deployment %s: %w", deploymentName, err)
}
}
_, err = client.WorkflowService().SetWorkerDeploymentRampingVersion(ctx, &workflowservice.SetWorkerDeploymentRampingVersionRequest{
Namespace: ns,
DeploymentName: deploymentName,
Identity: "feature-deployment-deleter",
IgnoreMissingTaskQueues: true,
AllowNoPollers: true,
})
if err != nil {
// Try using unversioned string (needed if deployment was very old)
_, err = client.WorkflowService().SetWorkerDeploymentRampingVersion(ctx, &workflowservice.SetWorkerDeploymentRampingVersionRequest{
Namespace: ns,
DeploymentName: deploymentName,
Version: "__unversioned__",
BuildId: "__unversioned__",
Identity: "feature-deployment-deleter",
IgnoreMissingTaskQueues: true,
AllowNoPollers: true,
})
if err != nil {
return fmt.Errorf("failed to unset ramping version for deployment %s: %w", deploymentName, err)
}
return fmt.Errorf("failed to unset ramping version for deployment %s: %w", deploymentName, err)
}

// Delete all versions (with SkipDrainage to force delete)
for _, version := range deploymentInfo.WorkerDeploymentInfo.VersionSummaries {
_, err = client.WorkflowService().DeleteWorkerDeploymentVersion(ctx,
_, err = tClient.WorkflowService().DeleteWorkerDeploymentVersion(ctx,
&workflowservice.DeleteWorkerDeploymentVersionRequest{
Namespace: ns,
DeploymentVersion: version.DeploymentVersion,
Expand All @@ -143,12 +99,16 @@ func DeleteDeployment(ctx context.Context, deploymentName string) error {
}
}

client.WorkflowService().DeleteWorkerDeployment(ctx,
// Delete the deployment itself
_, err = tClient.WorkflowService().DeleteWorkerDeployment(ctx,
&workflowservice.DeleteWorkerDeploymentRequest{
Namespace: ns,
DeploymentName: deploymentName,
Identity: "features-deployment-deleter",
},
)
if err != nil {
return fmt.Errorf("failed to delete deployment %s: %w", deploymentName, err)
}
return nil
}
Loading