Fix migration workflow breaking change for OSS #9085
Merged
+321
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
commented
Jan 20, 2026
| return json.Unmarshal(data, &e.executionInfoNewJSON) | ||
| } | ||
|
|
||
| // For forward compatibility, support both workflow_id and business_id here |
Member
Author
There was a problem hiding this comment.
This gives us forward compatibility in oss and in next oss release (1.31), we can always encoded to business_id.
yux0
reviewed
Jan 20, 2026
dnr
reviewed
Jan 21, 2026
5 tasks
yycptt
changed the title
Member
Author
|
The change for cloud is in #9097 |
yux0
approved these changes
Jan 23, 2026
simvlad
pushed a commit
that referenced
this pull request
Jan 27, 2026
## What changed? - Use plain go struct inside migration workflow activity input output - Customize the json encoding/decoding for migration execution info and make it backward & forward compatible. - This will temporary break cloud and the fix is in #9097 - This PR needs to be part of oss v1.30 release. ## Why? - Backward compatibility and less confusion over how the encoding will be done. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [x] added new unit test(s) - [ ] added new functional test(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?