Add metrics to track invalid search attributes comparisons in ES #9096
+68
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/persistence/visibility/store/elasticsearch/query_interceptors.go
Outdated
Show resolved
Hide resolved
awln-temporal
approved these changes
Jan 26, 2026
rodrigozhou
force-pushed
the
rodrigozhou/metrics-invalid-query
branch
from
20b6740 to
be26b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add metrics to track invalid search attributes comparisons in ES
Why?
Be able to track how often and which namespaces are using invalid comparisons.
How did you test it?
Potential risks