block internal system workflows and activities from getting triggered by users #9103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
feat/block-internal
branch
from
b9622e1 to
58f461a
Compare
feiyang3cat
commented
Jan 21, 2026
feiyang3cat
force-pushed
the
feat/block-internal
branch
4 times, most recently
from
c1c6b51 to
059ef1b
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
feat/block-internal
branch
from
059ef1b to
baf873d
Compare
feiyang3cat
force-pushed
the
feat/block-internal
branch
2 times, most recently
from
007b616 to
6757de7
Compare
feiyang3cat
changed the title
feiyang3cat
force-pushed
the
feat/block-internal
branch
7 times, most recently
from
17ee66a to
2ce1e74
Compare
feiyang3cat
commented
Jan 23, 2026
| } else if !pm.defaultQueueFuture.Ready() { | ||
| } | ||
| if !pm.defaultQueueFuture.Ready() { | ||
| return // not initialized yet |
Contributor
Author
There was a problem hiding this comment.
this line is refined without semantic changing for linter issues
feiyang3cat
force-pushed
the
feat/block-internal
branch
3 times, most recently
from
1ebda01 to
96e0b4f
Compare
feiyang3cat
force-pushed
the
feat/block-internal
branch
from
96e0b4f to
a34851c
Compare
Contributor
Author
|
this pr is closed and split into two prs for one workflow and one for activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
block end users using internal per-ns workers (workflows/activities) , pls note internal sys-ns related are not impacted
strategies:
(1) block by queue names in general-purpose APIs to create workflows, and let the usage of legal dedicated APIs pass
(2) activities and child workflows can be scheduled on internal per-ns queues only if the wrapping workflow runs on this queue
details for workflows:
details for activities:
Why?
enhanced resilience
How did you test it?
Potential risks
side-effects on legal system workflows/activities -> covered by regression testing (either unit or functional)