CHASM workflow command handler for Nexus #9109
Conversation
stephanos
changed the title
stephanos
force-pushed
the
nexus-chasm-commands
branch
12 times, most recently
from
0225b74 to
15b2305
Compare
| return []*chasm.RegistrableComponent{ | ||
| chasm.NewRegistrableComponent[*Operation]("operation"), | ||
| chasm.NewRegistrableComponent[*Operation]("cancellation"), | ||
| chasm.NewRegistrableComponent[*Cancellation]("cancellation"), |
stephanos
force-pushed
the
nexus-chasm-commands
branch
4 times, most recently
from
5521052 to
125a6f1
Compare
stephanos
force-pushed
the
nexus-chasm-commands
branch
3 times, most recently
from
3d0f476 to
cfe0179
Compare
| Callbacks chasm.Map[string, *callback.Callback] | ||
|
|
||
| // Operations map is used to store the nexus operations for the workflow. | ||
| Operations chasm.Map[string, *nexusoperation.Operation] |
There was a problem hiding this comment.
Not used yet, but demonstrates why command registry and types need to live in submodule. If they didn't there'd be an import cycle. Having this already ensures this design will work.
stephanos
force-pushed
the
nexus-chasm-commands
branch
5 times, most recently
from
ceadf56 to
69632f8
Compare
|
|
||
| // FailWorkflowTaskError is an error that can be returned from a [CommandHandler] to fail the current workflow task and | ||
| // optionally terminate the entire workflow. | ||
| type FailWorkflowTaskError struct { |
There was a problem hiding this comment.
Moving this to CHASM now to break up import cycle.
| } | ||
|
|
||
| // CommandValidator is a helper for validating workflow commands. | ||
| type CommandValidator interface { |
There was a problem hiding this comment.
Moved to CHASM, too. More from this package might be moved in follow-up PRs.
stephanos
force-pushed
the
nexus-chasm-commands
branch
10 times, most recently
from
49c85f6 to
3dca870
Compare
| // Logger returns a logger tagged with execution key and other chasm framework internal information. | ||
| Logger() log.Logger | ||
| // Library returns a registered library by name. | ||
| Library(name string) (Library, bool) |
There was a problem hiding this comment.
I had to add this to be able to access the Workflow library to get the command registry. Let me know if this is in line with the CHASM design!
stephanos
force-pushed
the
nexus-chasm-commands
branch
4 times, most recently
from
bf830b5 to
b6d0074
Compare
| ctx chasm.MutableContext, | ||
| msPointer chasm.MSPointer, | ||
| ) *Workflow { | ||
| lib, ok := ctx.Library(chasm.WorkflowLibraryName) |
There was a problem hiding this comment.
I think it's fair to assume that this is always registered.
stephanos
changed the title
stephanos
force-pushed
the
nexus-chasm-commands
branch
from
b6d0074 to
920f1f3
Compare
| ) error { | ||
| // TODO: Implement CHASM nexus operation cancellation | ||
| return serviceerror.NewUnimplemented("CHASM nexus operation cancellation not yet implemented") | ||
| } |
There was a problem hiding this comment.
My understanding is that we also want to support standalone Nexus operations, and this here might tie this module to workflows too tightly - so we could move all this into chasm/lib/nexusoperation/nexusworkflow (now or later) to make that distinction clearer.
| deps.Config, | ||
| ) | ||
| }), | ||
| ) |
There was a problem hiding this comment.
Copilot suggested moving the initialization from Nexus' fx to here; which made sense to me because of standalone Nexus operations. Having said that, this is also awkward in scenarios like Matching where there is no Nexus (hence the optional deps). Happy to discuss!
There was a problem hiding this comment.
(new thought; could move this bit and the command code both into chasm/lib/nexusoperation/nexusworkflow together)
1 participant
What changed?
Why?
Migrating Nexus from HSM to CHASM.
How did you test it?
Tests will be ported over once actual command handler implementations are added.